chore(deps): bump line-wrap to 0.2.0
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cijiugechu - Thanks for the PR. I was just about to raise one when I saw this. 👍🏽 |
|
Is there anything blocking this PR from being merged? Except that the CI is a bit sad, I think OP will need to change some imports slightly. I too would love to get rid of |
|
These look like failures from a new nightly-only lint, but happy to bump the safemem version. |
ebarnard
force-pushed
the
bump-line-wrap
branch
from
542a87e
to
e4eb643
Compare
nazmulidris
added a commit
to r3bl-org/r3bl-open-core
that referenced
this pull request
Apr 15, 2024
…all ambiguous names to be explicit This is an attempt to isolate the use of syntect to just 1 crate: r3bl_tui. It has been removed from the core crate. However, it is not possible to remove syntect from the lolcat / color_wheel modules as they are intrinsically tied together. Basically, they need to be able to render output, and for that they need to be in the r3bl_tui crate which has a dependency on syntect and this can't be removed. safemem is no longer maintained, you can see the following output from running cargo deny check advisories. 180 │ safemem 0.3.3 registry+https://github.com/rust-lang/crates.io-index │ ------------------------------------------------------------------- unmaintained advisory detected │ = ID: RUSTSEC-2023-0081 = Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0081 = The latest crates.io release was in 2019. The repository has been archived by the author. = Announcement: https://github.com/abonander/safemem = Solution: No safe upgrade is available! = safemem v0.3.3 └── line-wrap v0.1.1 └── plist v1.6.0 └── syntect v5.1.0 └── r3bl_tui v0.5.2 └── r3bl-cmdr v0.0.11 More info: - #314 - ebarnard/rust-plist#134 - trishume/syntect#521 This `safemem` issue is resolved since the dependencies of syntect, `line-wrap` and `plist` are both updated. By pinning the version of `plist` to `1.6.1` (`cargo update -p plist --precise 1.6.1`) and checking in `Cargo.toml`, this resolves the `safemem` issue.
nazmulidris
added a commit
to r3bl-org/r3bl-open-core
that referenced
this pull request
Apr 15, 2024
…all ambiguous names to be explicit This is an attempt to isolate the use of syntect to just 1 crate: r3bl_tui. It has been removed from the core crate. However, it is not possible to remove syntect from the lolcat / color_wheel modules as they are intrinsically tied together. Basically, they need to be able to render output, and for that they need to be in the r3bl_tui crate which has a dependency on syntect and this can't be removed. safemem is no longer maintained, you can see the following output from running cargo deny check advisories. 180 │ safemem 0.3.3 registry+https://github.com/rust-lang/crates.io-index │ ------------------------------------------------------------------- unmaintained advisory detected │ = ID: RUSTSEC-2023-0081 = Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0081 = The latest crates.io release was in 2019. The repository has been archived by the author. = Announcement: https://github.com/abonander/safemem = Solution: No safe upgrade is available! = safemem v0.3.3 └── line-wrap v0.1.1 └── plist v1.6.0 └── syntect v5.1.0 └── r3bl_tui v0.5.2 └── r3bl-cmdr v0.0.11 More info: - #314 - ebarnard/rust-plist#134 - trishume/syntect#521 This `safemem` issue is resolved since the dependencies of syntect, `line-wrap` and `plist` are both updated. By pinning the version of `plist` to `1.6.1` (`cargo update -p plist --precise 1.6.1`) and checking in `Cargo.toml`, this resolves the `safemem` issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Update line-wrap to 0.2 to avoid RUSTSEC-2023-0081 (safemem is unmaintained)