Skip to content
This repository has been archived by the owner on Jan 1, 2019. It is now read-only.

ParallelClient responseContent enconding #46

Closed
jeffpeiyt opened this issue Oct 13, 2016 · 6 comments
Closed

ParallelClient responseContent enconding #46

jeffpeiyt opened this issue Oct 13, 2016 · 6 comments

Comments

@jeffpeiyt
Copy link
Contributor

Issue raised in https://groups.google.com/forum/#!topic/parallec/MB2QyGGnwTk

Need to add a parameter in http meta to get the response body with the proper encoding.

public String getResponseBody(String charset) throws IOException;
response.getResponseBody("UTF-8")

@jeffpeiyt
Copy link
Contributor Author

Customer indicates he is working on patching this. Close it for now and may reopen it if need further action

@ghost
Copy link

ghost commented Jun 20, 2017

Any news on this issue? Encoding bug makes parallec unusable for production.

@jeffpeiyt jeffpeiyt reopened this Jun 20, 2017
@jeffpeiyt
Copy link
Contributor Author

jeffpeiyt commented Jun 20, 2017

@devnewton busy recently but should get it in 1 week.
It is better to pass a parameter per task but setting a global one from https://github.com/eBay/parallec/blob/master/src/main/java/io/parallec/core/config/ParallecGlobalConfig.java would be super easy. (and you can overwrite any values very easily before calling parallec)
http://www.parallec.io/docs/configurations/

https://asynchttpclient.github.io/async-http-client/apidocs/com/ning/http/client/Response.html#getResponseBody(java.lang.String)

Need to add a parameter in http meta to get the response body with the proper encoding.

public String getResponseBody(String charset) throws IOException;
response.getResponseBody("UTF-8")

Do you currently have tasks where each response needs different encodings?

jeffpeiyt added a commit that referenced this issue Jun 24, 2017
@jeffpeiyt
Copy link
Contributor Author

@ghost
Copy link

ghost commented Jun 24, 2017

Thanks!

@jeffpeiyt
Copy link
Contributor Author

Released 0.10.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants