Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

OBA preferred root node and show part_of hierarchy #653

Closed
rays22 opened this issue Nov 30, 2022 · 11 comments · Fixed by EBISPOT/OLS-Config#8
Closed

OBA preferred root node and show part_of hierarchy #653

rays22 opened this issue Nov 30, 2022 · 11 comments · Fixed by EBISPOT/OLS-Config#8
Assignees

Comments

@rays22
Copy link

rays22 commented Nov 30, 2022

Based on feedback from some confused users who tried to navigate the Ontology of Biological Attributes (OBA) I am wondering if
* OLS could display a preferred root node OBA:0000001 for OBA, and if
* OLS could show materialised part-of relationships in OBA with blue 'P' icons as it does, for example, in the Uberon hierarchy.

There are several newer releases than the currently displayed OBA v2022-08-03, and it would be great to see the latest OBA release with the enhancements I am suggesting above.

@matentzn
Copy link
Contributor

@rays22 the first (root node) will happen automatically at the next load. For the second, we need to edit the hierarchical properties in the OLS config. @serjoshua can you remind me where this is hosted?

@serjoshua
Copy link
Contributor

serjoshua commented Nov 30, 2022

Hello Nico and Ray!

Yes, we could handle configuration (overrides) besides what is in OBO Foundry. Those overrides could be found here. You could also see there examples of other configuration that some ontologies have, such as hierarchical_property, as mentioned. As for the data update, we will add OBA to our next data release mid-December. It would be better as well if we already have the configuration for the hierarchical_property before the release so it will be included in the update. Otherwise, we will keep you posted regarding the release. Regards.

Josh

@serjoshua serjoshua self-assigned this Nov 30, 2022
@matentzn
Copy link
Contributor

@rays22 will you deal with adding the part of as an hierarchical property?

rays22 added a commit to rays22/OLS-Config that referenced this issue Nov 30, 2022
@rays22
Copy link
Author

rays22 commented Nov 30, 2022

OK, I have added the following snippet to EBISPOT/OLS-Config/prod/ols-ontologies.yaml

## OBA override
  - id: oba
    hierarchical_property:
      - http://purl.obolibrary.org/obo/BFO_0000050

and created a PR EBISPOT/OLS-Config#8 .
@serjoshua, please, let me know , if anything is missing or if it is not what you need.

@serjoshua
Copy link
Contributor

Good morning Ray, that is just exactly what we need. Thank you. We will keep you posted regarding the release. Re-opening this ticket until OBA has been updated in OLS.

@serjoshua serjoshua reopened this Dec 1, 2022
@rays22
Copy link
Author

rays22 commented Dec 1, 2022

Thank you Josh.

@jonquet
Copy link

jonquet commented Dec 1, 2022

@serjoshua quick question: is there a list somewhere of all the properties that can be "overrided" ?
Could be interesting candidates for extending MOD (metadata for ontologies)... we do already have in MOD a few metadata properties to describe the properties used to define objects...

@serjoshua
Copy link
Contributor

serjoshua commented Dec 1, 2022

Hello Clement,

That is actually a good question. I'm not an expert in ontologies, OWL standards and the like, but we have a documentation on how to add ontologies in OLS and in the spreadsheet/form that we provide there, we have five (5) property configurations that we accept:

  • label_property
  • definition_property
  • synonym_property
  • hierarchical_property
  • hidden_property

I hope it helps. Regards.

@jonquet
Copy link

jonquet commented Dec 1, 2022

Thanks.
Good we already have some matches:

We also have in MOD2

Can you clarify the meaning of hidden_property ?
This is a bit similar to obseolete to me, but if this is a porperty that has only value in OLS UI to avoid displaying the property on the screen... then it does not belongs to MOD I believe (that the policy we took first time we review a bunch of ontology repositories (including OLS) when we did MOD1.4).

@serjoshua
Copy link
Contributor

Thank you. That is a good observation. I actually just checked our code and it seems like we are not using it anymore or about to discontinue. Apologies if my earlier response confused you. So, it seems like we only have the other four properties properly supported as of the moment. Let me know if you have other questions. Regards.

@rays22
Copy link
Author

rays22 commented Feb 24, 2023

The preferred root node OBA:0000001 is displayed for OBA on OLS.
Thank you @serjoshua !

@rays22 rays22 closed this as completed Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants