Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Arm64 iOS with Go 1.15 #37

Closed
hajimehoshi opened this issue Sep 7, 2022 · 2 comments
Closed

support Arm64 iOS with Go 1.15 #37

hajimehoshi opened this issue Sep 7, 2022 · 2 comments
Assignees
@TotallyGamerJet

Comments

@hajimehoshi
Copy link
Contributor

Now Go 1.15 for Arm64 iOS doesn't work as callbackWrapPicker is missing.

We don't have to care about macOS since Go 1.15 doesn't support Arm macOS. This support started as of Go1.16.

This is nice to have and low priority.
@hajimehoshi
Copy link
Contributor Author

hajimehoshi commented Sep 7, 2022 •
edited
Loading

https://cs.opensource.google/go/x/mobile/+/master:go.mod

Go mobile itself doesn't support Go 1.15, so the target would be a user who still uses a pretty old Go mobile...

@hajimehoshi hajimehoshi mentioned this issue Sep 10, 2022
Merged
@hajimehoshi hajimehoshi changed the title support Arm64 iOS with Go 115 support Arm64 iOS with Go 1.15 Sep 10, 2022
hajimehoshi added a commit that referenced this issue Sep 10, 2022
@hajimehoshi
purego: skip importing runtime/cgo for Windows (#41)
e8e2e45 
This change resolves these issues:

* Buiding purego for `GOOS=darwin` and `GOARCH=arm64` with Go 1.15
  is not supported so far (#37). Skip this.
* Buiding purego for `GOOS=windows` with Cgo failed due to duplicated
  symbols (#39). Let's not import `runtime/cgo` for Windows. `fakecgo` is
  implemented only for Darwin so this should be fine. As a side effect, purego
  can no longer be imported from non-Darwin or non-Windows so far.

Updates #37
Closes #39
@TotallyGamerJet TotallyGamerJet mentioned this issue Sep 12, 2022
Closed
@hajimehoshi
Copy link
Contributor Author

We don't have to do this per #43.

@hajimehoshi hajimehoshi closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TotallyGamerJet TotallyGamerJet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hajimehoshi @TotallyGamerJet