-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purego: skip importing runtime/cgo
for Windows
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please take a look, thanks |
runtime/cgo
for Windowsruntime/cgo
for Windows
hajimehoshi
commented
Sep 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts?
Why the swap? |
I think it's reverted. |
TotallyGamerJet
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves these issues:
GOOS=darwin
andGOARCH=arm64
with Go 1.15is not supported so far (support Arm64 iOS with Go 1.15 #37). Skip this.
GOOS=windows
with Cgo failed due to duplicatedsymbols (
go build
a main package with purego with Cgo enabled might fail on Windows and Linux #39). Let's not importruntime/cgo
for Windows.fakecgo
isimplemented only for Darwin so this should be fine. As a side effect, purego
can no longer be imported from non-Darwin or non-Windows so far.
Updates #37
Closes #39