Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons appear with different height #98

Open
gpmaccari opened this issue Jul 14, 2017 · 1 comment
Open

Some icons appear with different height #98

gpmaccari opened this issue Jul 14, 2017 · 1 comment

Comments

@gpmaccari
Copy link

The group icon icon-fileformats appear with different height. This is evident when they are next to other group icons. That's because they seems to have font-size: 123.1%.
At the moment I resolved by adding a css class icon-fixed:

.icon-fixed::before{ font-size: 100%;}

@khawkins98
Copy link
Contributor

Finally getting to this one.

It's actually a problem with the ebiwd/EBI-Icon-fonts

It's a setting that was inherited before it was source controlled and I imagine it's because at 100% the file names are quite hard to read, though I would agree consistency would be better.

Perhaps we:

  1. Set the size to 100%
  2. Better document the .size-125 pattern so that users can tweak as needed (https://www.ebi.ac.uk/style-lab/websites/patterns/formatting.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants