Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can this be used to set an .exe's icon? #46

Closed
nedtwigg opened this issue Jun 5, 2018 · 2 comments
Closed

Can this be used to set an .exe's icon? #46

nedtwigg opened this issue Jun 5, 2018 · 2 comments
Labels
enhancement

Comments

@nedtwigg
Copy link

nedtwigg commented Jun 5, 2018

I know that's not the primary purpose, but PEFile looks to be a very clean implementation. Would it be crazy to use it to set the icon of an exe?
@ebourg
Copy link
Owner

ebourg commented Jun 5, 2018

Why not, I designed PEFile to be generic and I'm fine with adding this feature if someones provides the implementation.

@ebourg
Copy link
Owner

ebourg commented Jun 17, 2021

I won't have the time to implement this, but if someone provides a PR I'll review it.

@ebourg ebourg closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebourg @nedtwigg