Skip to content

Commit

Permalink
fix(modal): remove aria-hidden on the icon - FRONT-4356 (#3331)
Browse files Browse the repository at this point in the history
  • Loading branch information
emeryro committed Apr 8, 2024
1 parent cfb83a8 commit 24b6813
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[`Modal Collapsed information, renders correctly 1`] = `
class="ecl-modal__header"
>
<svg
aria-hidden="true"
aria-hidden="false"
class="ecl-icon ecl-icon--l ecl-modal__icon"
focusable="false"
role="img"
Expand Down
1 change: 1 addition & 0 deletions src/implementations/twig/components/modal/modal.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
name: _header_icon,
size: 'l',
},
as_image: true,
extra_accessibility: not _sr_icon ? {} : {
title: _sr_icon,
},
Expand Down

1 comment on commit 24b6813

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.