New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): remove aria-hidden on the icon - FRONT-4356 #3331

Merged

planctus merged 2 commits into v4-dev from FRONT-4356-acc-modal-icon-hidden

Apr 8, 2024

Contributor

emeryro commented Apr 4, 2024

set aria-hidden=false on the icon, to allow screen reader to acess the textual indication


          remove aria-hidden

0fb4482

emeryro added tag: bug fix process: review needed labels


          update test

d8fe320

emeryro added the tag: markup changes label

github-actions bot commented Apr 4, 2024 •

edited

🚀 Deployed on https://ecl-preview-3331--europa-component-library.netlify.app

github-actions bot temporarily deployed to pull request

April 4, 2024 10:59

Inactive

planctus approved these changes

View reviewed changes

planctus removed the process: review needed label

planctus merged commit 24b6813 into v4-dev

7 checks passed

planctus deleted the FRONT-4356-acc-modal-icon-hidden branch

April 8, 2024 12:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment