Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ie11): fix js error - INNO-1988 #1438

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@emeryro
Copy link
Contributor

emeryro commented Dec 2, 2019

PR description

Fix javascript error on some component, on IE11 (it was only visible on the website).
Error message: Object doesn't support property or method 'values'
Components:

  • fact and figures
  • site header core
  • site header harmonised
  • site header standardised
@emeryro emeryro requested a review from ec-europa/inno as a code owner Dec 2, 2019
@yhuard
yhuard approved these changes Dec 2, 2019
Copy link
Contributor

yhuard left a comment

I confirm the bug is fixed

@yhuard yhuard merged commit e80fec1 into v2-dev Dec 2, 2019
3 checks passed
3 checks passed
Semantic Pull Request ready to be squashed
Details
continuous-integration/drone/push the build was successful
Details
drone/netlify Preview ready!
Details
@yhuard yhuard deleted the fix/ie11-js-error-INNO-1988 branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.