feat(horizontal-menu): add component - INNO-595 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuard
suggested changes
Jun 15, 2017
There was a problem hiding this comment.
Please read https://www.w3.org/WAI/GL/wiki/Using_ARIA_menus and https://formidable.com/blog/2014/05/08/anchors-buttons-and-accessibility/, then let's discuss it
|
In overall works well. |
kalinchernev
approved these changes
Jun 16, 2017
degliwe
reviewed
Jun 19, 2017
yhuard
approved these changes
Jun 19, 2017
degliwe
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brand new component.
Specifications are in Jira ticket.
Note: currently, opening a group do not close the other ones. It will be added once the "accordion" component is available on ECL (in a follow-up ticket)Won't do: