Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site-header): add component - FRONT-3530 #2318

Merged
merged 23 commits into from
Mar 30, 2022
Merged

Conversation

@github-actions
Copy link

github-actions bot commented Jan 27, 2022

@emeryro emeryro removed their assignment Jan 27, 2022
@emeryro emeryro changed the title feat(site-header): add component feat(site-header): add component - FRONT-3530 Jan 27, 2022
papegaill
papegaill previously approved these changes Feb 2, 2022
@papegaill
Copy link
Contributor

@emeryro PR is approved on my side, however, you need to update packages to v3.2.2 and fix the conflict.

papegaill
papegaill previously approved these changes Feb 10, 2022
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emeryro I just realised, the svg thumbnails for EC & EU documentation pages. I ask the designers.

@papegaill papegaill merged commit 351db5a into v3-dev Mar 30, 2022
@papegaill papegaill deleted the FRONT-3530-site-header branch March 30, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants