feat(banner): add coypright - FRONT-3616 #2404
Conversation
1 similar comment
…uropa-component-library into FRONT-3616-copyright
| @@ -36,6 +36,23 @@ $_font-weight: null !default; | |||
| position: relative; | |||
| } | |||
|
|
|||
| .ecl-hero-banner__copyright { | |||
There was a problem hiding this comment.
it's true that we only use this twice, but couldn't we make a mixin and include it where needed, instead of duplicating these rules..?
There was a problem hiding this comment.
we are already duplicating all the other rules for the banners.
We could have some generic banner css, and just change what correspond to page or hero banner. But I would keep this for another ticket
| if (data.image) { | ||
| argTypes.show_copyright = { |
There was a problem hiding this comment.
this control seems uneffective, you don't use it to control the display of the copyright.
| @@ -58,6 +60,9 @@ | |||
| <section class="{{ _css_class }}"{{ _extra_attributes|raw }}> | |||
| {% if _image is not empty and _variant in ['image', 'image-shade', 'image-gradient'] %} | |||
| <div class="ecl-page-banner__image" style="background-image:url({{ _image }})"></div> | |||
| {% endif %} | |||
| {% if _copyright is not empty and _variant in ['image', 'image-shade', 'image-gradient'] %} | |||
There was a problem hiding this comment.
I wonder if this is the right approach. i mean that i would imagine a use case where the copyright is needed but no text would be associated to it, not sure if it's a valid use case but in this case we should probably have a boolean to control the display and a text parameter to set an optional text, but you know what the requirements are better than me..
Add optional copyright to banners and carousel