feat(featured-media): Add position parameter - FRONT-3638 #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
requested changes
May 30, 2022
src/implementations/vanilla/components/featured-item/_featured-item.scss
Outdated
Show resolved
Hide resolved
src/website/src/pages/eu/components/media/featured-item/demo/index.js
Outdated
Show resolved
Hide resolved
src/implementations/twig/components/featured-item/featured-item.html.twig
Outdated
Show resolved
Hide resolved
papegaill
changed the title
emeryro
requested changes
Jun 1, 2022
| system="eu" | ||
| selectedKind="components-featured-item" | ||
| selectedStory="default" | ||
| selectedArgs="alignment:right" |
There was a problem hiding this comment.
it should be "position" instead of "alignment" on these pages
| @@ -81,6 +82,17 @@ const getArgTypes = (data) => { | |||
| }; | |||
| } | |||
|
|
|||
| argTypes.alignment = { | |||
There was a problem hiding this comment.
it should be changed to position too, for consistency
| @@ -12,6 +12,7 @@ const getArgs = (data) => { | |||
| heading: data.heading, | |||
| title: data.title, | |||
| description: data.description, | |||
| alignment: 'left', | |||
There was a problem hiding this comment.
Suggested change
| alignment: 'left', | |
| position: 'left', |
emeryro
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.