-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): add parameter for enhanced mobile - FRONT-3754 #2653
Conversation
…y into v3.5.0-dev
…y into v3.5.0-dev
…y into v3.5.0-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, while making this optional is a really good way to avoid breaking potentially correct tables, this way we lose any "responsiveness" for tables.
Shouldn't we introduce something like bootstrap does..? And maybe apply this by default, if the user wants he can use the enhanced when it's going to improve the mobile look and feel.
https://getbootstrap.com/docs/5.0/content/tables/#responsive-tables
}, | ||
}); | ||
|
||
const prepareData = (data, args) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can simply be const prepareData = (data, args) => Object.assign(data, args);
, no..?
|
||
## Enhanced mobile table | ||
|
||
Enhanced tables offers a more user friendly display on mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why we don't specify what are the "tables" where this can be safely enabled..? I mean, for this to work we need the first tr to contain th(s) as a basic requirement.
Then this might not be enough in 100% of the cases, so this is why making this optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one thing that we are not handling, but i don't see how could we, if created in the wyswyg editor the table will not be responsive, unless they do something on the implementation side..
Co-authored-by: planctus <davidepuntoferrante@gmail.com>
…y into v3.6.0-dev
Co-authored-by: planctus <davidepuntoferrante@gmail.com>
…y into v3.6.0-dev
…brary into v3.6.0-dev
Co-authored-by: planctus <davidepuntoferrante@gmail.com>
Co-authored-by: Romain Emery <emery.romain@gmail.com>
Add a parameter to disable the enhanced mobile display. If set, table will only have an horizontal scroll on small screens