Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): Resetting static dirs when building - FRONT-3789 #2682

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Nov 7, 2022

This removes this error in the build:

(node:6414) UnhandledPromiseRejectionWarning: Error: EEXIST: file already exists, mkdir '/home/runner/work/europa-component-library/europa-component-library/src/playground/ec/build/styles'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:6414) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:6414) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:6414) UnhandledPromiseRejectionWarning: Error: EEXIST: file already exists, mkdir '/home/runner/work/europa-component-library/europa-component-library/src/playground/ec/build/styles'
(node:6414) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

We are not asking anymore storybook to copy files from the static folders we need when building, basically.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do a full build after cleaning my folder, and it seems that resources are missing for storybook (running yarn start:eu)
image

@planctus
Copy link
Contributor Author

wow, thank god you tested this.. :)

@emeryro emeryro merged commit 7de4741 into v3-dev Nov 22, 2022
@emeryro emeryro deleted the FRONT-3789-Static-dirs branch November 22, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants