Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): Resetting static dirs when building - FRONT-3789 #2682

Merged
merged 7 commits into from
Nov 22, 2022
Merged

fix(storybook): Resetting static dirs when building - FRONT-3789 #2682

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ba3de1
fix(storybook): Resetting static dirs when building - FRONT-3789
planctus Nov 7, 2022
920285f
Merge branch 'v3-dev' into FRONT-3789-Static-dirs
planctus Nov 7, 2022
785a807
Merge branch 'v3-dev' into FRONT-3789-Static-dirs
planctus Nov 8, 2022
2f5c1a9
Merge branch 'v3-dev' into FRONT-3789-Static-dirs
emeryro Nov 15, 2022
b297638
fix(build): Fixing fix :) - FRONT-3789
planctus Nov 17, 2022
0e71e30
Merge branch 'v3-dev' into FRONT-3789-Static-dirs
planctus Nov 17, 2022
d909c9e
Merge branch 'v3-dev' into FRONT-3789-Static-dirs
emeryro Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/playground/ec/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const path = require('path');
const webpack = require('webpack');

const isBuild = process.env.NODE_ENV;
const isProd = process.env.NODE_ENV === 'production';
const outputFolder = isProd ? 'dist' : 'build';

Expand All @@ -18,12 +19,17 @@ const addons = [
'@storybook/addon-a11y',
];

const staticDirs = [
let staticDirs = [
path.resolve(`${__dirname}/../../../presets/ec/${outputFolder}`),
path.resolve(`${__dirname}/../../../presets/reset/${outputFolder}`),
path.resolve(`${__dirname}/../../../presets/rtl/${outputFolder}`),
];

// FRONT-3789 - No need for static dirs, we manually copy the files.
if (isBuild) {
staticDirs = [];
}

const webpackFinal = (config) => {
// Trick "babel-loader", force it to transpile @ecl addons
config.module.rules[0].exclude = /node_modules\/(?!@ecl\/).*/;
Expand Down
8 changes: 7 additions & 1 deletion src/playground/eu/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const path = require('path');
const webpack = require('webpack');

const isBuild = process.env.NODE_ENV;
const isProd = process.env.NODE_ENV === 'production';
const outputFolder = isProd ? 'dist' : 'build';

Expand All @@ -18,12 +19,17 @@ const addons = [
'@storybook/addon-a11y',
];

const staticDirs = [
let staticDirs = [
path.resolve(`${__dirname}/../../../presets/eu/${outputFolder}`),
path.resolve(`${__dirname}/../../../presets/reset/${outputFolder}`),
path.resolve(`${__dirname}/../../../presets/rtl/${outputFolder}`),
];

// FRONT-3789 - No need for static dirs, we manually copy the files.
if (isBuild) {
staticDirs = [];
}

const webpackFinal = (config) => {
// Trick "babel-loader", force it to transpile @ecl addons
config.module.rules[0].exclude = /node_modules\/(?!@ecl\/).*/;
Expand Down