-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expandable): add expandable - INNO-1288 #973
Conversation
Deploy preview for europa-component-library ready! Built with commit b1bf26c https://deploy-preview-973--europa-component-library.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR on hold
...ems/ec/implementations/vanilla/packages/ec-component-expandable/ec-component-expandable.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there might have been a misunderstanding: an expandable never involves a link (it's not the purpose of a link to trigger expandables)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last thing and then I think we're good: React packages must be private (see https://github.com/ec-europa/europa-component-library/blob/v2/src/systems/ec/implementations/react/packages/button/package.json)
React packages are now private |
PR description
Add expandable, based on specifications