Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug: regItemProposedToRegItem method #75

Closed
dhbello opened this issue Nov 2, 2021 · 1 comment
Closed

Possible bug: regItemProposedToRegItem method #75

dhbello opened this issue Nov 2, 2021 · 1 comment
Labels
solved Solution developed and accepted, not yet deployed Type: Bug Something isn't working
Milestone

Comments

@dhbello
Copy link
Contributor

dhbello commented Nov 2, 2021

I believe that there is a bug when a relation field is tried to be updated (a single value field gets two values). To reproduce it, follow these steps:

  • Update any item relation field (RegItemproposedHandler.updateFields creates with two RegLocalizationProposed records - two different fieldValueIndex)
  • Follow all the acceptance process (submit the action, approve it, etc)
  • When the admin is going to publish the action (RegItemHandler.regItemProposedToRegItem method), the previous value (ej: fieldValueIndex 0) is not deleted, and the new value (ej: fieldValueIndex 1) is saved. Therefore, a single value field receives two values.

My solution was before create/save RegLocalization values, previously delete and renumerate fieldValueIndex values, however, I'm not sure if this is a bug, so I didn't submit a merge/patch.

@emanuelaepure10 emanuelaepure10 added the under analysis A first analysis is performing label Nov 10, 2021
@oscar9 oscar9 added the Type: Bug Something isn't working label Jun 3, 2022
@arantzaetxebarria arantzaetxebarria added this to the v2.4.1 milestone Nov 30, 2022
@oruscalleda oruscalleda added solved Solution developed and accepted, not yet deployed and removed under analysis A first analysis is performing labels Dec 23, 2022
@oruscalleda
Copy link
Collaborator

This bug is no longer reproducible, so this issue will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved Solution developed and accepted, not yet deployed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants