Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard improvements #3155

Closed
4 of 5 tasks
manuelmeister opened this issue Nov 11, 2022 · 3 comments
Closed
4 of 5 tasks

Dashboard improvements #3155

manuelmeister opened this issue Nov 11, 2022 · 3 comments

Comments

@manuelmeister
Copy link
Member

manuelmeister commented Nov 11, 2022

Continuation from #3150

  • Skeleton loader for the table
  • Persist the filters in the URL, for sharing filtered lists and so that when navigating to an activity and back, the same filters are restored Persist dashboard filters in query params #3406
  • Days should not be loaded with individual network requests when navigating to the dashboard from another page
  • Simplify durations (removing 0min when it's only 2h 0min)
  • Distinguish clear in SelectFilter from other options
@carlobeltrame
Copy link
Member

Most of this was already included in #3150.

The days loading issue I could not reproduce. @usu does this really still happen? Can you provide a way to reproduce it?

Other than that, this issue more or less becomes an issue to discuss how to store the filters. We could store it in the URL, but it would get quite long because we use URIs, not ids now. Or we could store it in the Vuex store, but then it would get lost when reloading the page, and the filtered list wouldn't be shareable by link.

@usu
Copy link
Member

usu commented Nov 12, 2022

The days loading issue I could not reproduce. @usu does this really still happen? Can you provide a way to reproduce it?

Yes, I can consistently reproduce. Adressed in #3158
When I load the dashboard directly, a network request to /camps/123 is made, which comes with a lot of embedded data. When I navigate from /camps to the the dashboard, no such request is made because the camp is already known. But then days and campCollaborations are unknown and hence loaded with separate requests.

DeNic0la added a commit to DeNic0la/ecamp3 that referenced this issue Jun 5, 2023
DeNic0la added a commit to DeNic0la/ecamp3 that referenced this issue Aug 1, 2023
# Conflicts:
#	frontend/src/views/camp/Dashboard.vue
DeNic0la added a commit to DeNic0la/ecamp3 that referenced this issue Aug 6, 2023
@BacLuc
Copy link
Contributor

BacLuc commented Apr 27, 2024

seems to be better

@BacLuc BacLuc closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants