New dashboard #3150
New dashboard #3150
Conversation
| </template> | ||
|
|
||
| <script> | ||
| import AvatarRow from './AvatarRow.vue' |
There was a problem hiding this comment.
When do we relative import components and when via the @ notation?
There was a problem hiding this comment.
I do so more or less at random. I try to avoid too many ../../../../, and especially try to import from the symlinked common instead of the common folder outside the frontend folder. But most of the time I let phpstorm manage this
There was a problem hiding this comment.
Just my 2 cents:
- Relative paths make refactoring easy, if the components are tightly coupled (mostly for components in the same folder or subfolders). In this example I could rename or move the dashboard folder, and things just work (1 path only to fix).
- For anything else (usage of generic components, base components, etc.) I normally use @ because it's easier to search & replace in case of refactoring. Any ../../../../ thing is super difficult to catch and relies a lot on IDE magic for refactoring.
| <span class="e-subtitle">{{ duration }}</span> | ||
| </td> | ||
| <td style="width: 100%" class="contentrow"> | ||
| <router-link :to="routerLink" class="text-decoration-none black--text"> |
There was a problem hiding this comment.
I'd vote to keep the text-decoration here. It's visually not easy to see that titles are links but the rest not.
And it would make it consistent with "story" view (activity titles also links). Not mission critical, so can also be discussed/come in separate improvements.
There was a problem hiding this comment.
I'm not sure how to handle this yet generally. I would like to develop a concept for such links #3153. Just on GitHub they have different ways as well, so I'm not sure if everything needs to be the same.
I think for the moment we can leave this as is.
There was a problem hiding this comment.
I think the links are a little hidden right now as well. But adding all the underlines makes the view very nervous. Ideally, I'd like the whole row to be clickable, but that's not so easy with table rows to do in a semantically correct way last time I checked.
As a compromise, I added the underline only on hover. Not much help on mobile though.
|
@manuelmeister @usu thanks for the good inputs! All your comments should be adressed now. Please check again. In the meantime, did someone already start fixing the colorjs.io issue? There's also sentry issues for it. EDIT: #3154 |
| <v-list-item-title class="d-flex"> | ||
| <span class="flex-grow-1">{{ | ||
| $tc('components.dashboard.selectFilter.clear') | ||
| }}</span> | ||
| <v-icon right>mdi-close</v-icon> | ||
| </v-list-item-title> |
There was a problem hiding this comment.
Can you make it gray to reduce its importance? In my draft it was black because it was itself an option, now it just resets the filter.
Supersedes #3053
The chip colors and avatar colors unfortunately don't work on devel... In fact, the category chips have vanished completely. Maybe the colorjs.io package isn't compatible with our build process either? Oh well, we can fix that in a separate PR.#3154Ideas for optional further refinement (let me know what you'd like me to implement in this PR):