Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print: pin @vue dependencies, that they have the same version #4110

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Nov 13, 2023

There seem to be problems on version mismatches.
#4046
#3937

For print specifically: #4056
The PR for print: #4110

The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update.
Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.

@BacLuc
Copy link
Contributor Author

BacLuc commented Nov 28, 2023

Had to revert the vue update in the lock file maintenance here: ef72028

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: Write these into overrides instead of dev dependencies.

There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937

For print specifically: ecamp#4056

The transitive dependencies seem to be updated in the lock file maintenance.
The direct dependency in a normal package update.
Even in minor versions this seems to be a problem ->
we pin them together, and they get updated together.
@BacLuc BacLuc force-pushed the print-pin-vue-dependencies-together branch from e49fe7c to eeb2677 Compare December 9, 2023 13:11
@BacLuc BacLuc added this pull request to the merge queue Dec 9, 2023
Merged via the queue into ecamp:devel with commit c9d2b5c Dec 9, 2023
28 checks passed
@BacLuc BacLuc deleted the print-pin-vue-dependencies-together branch December 23, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants