Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update @vue/runtime-core to 3.3.7 #4046

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Nov 5, 2023

And also perform lock file maintenance.
The update of @vue/runtime-core to 3.3.5 did not play well without updating the other dependencies.
Resolving vue components did not work anymore with the warning: resolveComponent can only be used in render() or setup() And then the vue components were not resolved which lead the custom renderer to be called with the vue components, which it could not handle.
(Tag cannot be used inside a pdf. Did you forget to import a Vue component?)

And also perform lock file maintenance.
The update of @vue/runtime-core to 3.3.5 did not play well
without updating the other dependencies.
Resolving vue components did not work anymore with the warning:
resolveComponent can only be used in render() or setup()
And then the vue components were not resolved which lead
the custom renderer to be called with the vue components, which
it could not handle.
(Tag <SimpleComponent> cannot be used inside a pdf. Did you forget to import a Vue component?)
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like it was a temporary bug in vue-runtime-core? Fine by me

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let's try this

@manuelmeister manuelmeister added this pull request to the merge queue Nov 5, 2023
Merged via the queue into ecamp:devel with commit aedd52e Nov 5, 2023
28 checks passed
@BacLuc BacLuc deleted the pdf-update-vue-runtime-core branch November 6, 2023 09:28
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Nov 7, 2023
There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Nov 7, 2023
There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937

The transitive dependencies seem to be updated in the lock file maintenance.
The direct dependency in a normal package update.
Even in minor versions this seems to be a problem ->
we pin them together, and they get updated together.
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Nov 13, 2023
There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937

For print specifically: ecamp#4056

The transitive dependencies seem to be updated in the lock file maintenance.
The direct dependency in a normal package update.
Even in minor versions this seems to be a problem ->
we pin them together, and they get updated together.
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Dec 9, 2023
There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937

For print specifically: ecamp#4056

The transitive dependencies seem to be updated in the lock file maintenance.
The direct dependency in a normal package update.
Even in minor versions this seems to be a problem ->
we pin them together, and they get updated together.
BacLuc added a commit to BacLuc/ecamp3 that referenced this pull request Dec 9, 2023
There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937

The transitive dependencies seem to be updated in the lock file maintenance.
The direct dependency in a normal package update.
Even in minor versions this seems to be a problem ->
we pin them together, and they get updated together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants