-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update @vue/runtime-core to 3.3.7 #4046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also perform lock file maintenance. The update of @vue/runtime-core to 3.3.5 did not play well without updating the other dependencies. Resolving vue components did not work anymore with the warning: resolveComponent can only be used in render() or setup() And then the vue components were not resolved which lead the custom renderer to be called with the vue components, which it could not handle. (Tag <SimpleComponent> cannot be used inside a pdf. Did you forget to import a Vue component?)
This was referenced Nov 5, 2023
Merged
carlobeltrame
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like it was a temporary bug in vue-runtime-core? Fine by me
manuelmeister
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay let's try this
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Nov 7, 2023
There seem to be problems on version mismatches. ecamp#4046 ecamp#3937
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Nov 7, 2023
There seem to be problems on version mismatches. ecamp#4046 ecamp#3937 The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update. Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Nov 13, 2023
There seem to be problems on version mismatches. ecamp#4046 ecamp#3937 For print specifically: ecamp#4056 The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update. Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Dec 9, 2023
There seem to be problems on version mismatches. ecamp#4046 ecamp#3937 For print specifically: ecamp#4056 The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update. Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Dec 9, 2023
There seem to be problems on version mismatches. ecamp#4046 ecamp#3937 The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update. Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also perform lock file maintenance.
The update of @vue/runtime-core to 3.3.5 did not play well without updating the other dependencies.
Resolving vue components did not work anymore with the warning: resolveComponent can only be used in render() or setup() And then the vue components were not resolved which lead the custom renderer to be called with the vue components, which it could not handle.
(Tag cannot be used inside a pdf. Did you forget to import a Vue component?)