Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency puppeteer-core to v22 #4621

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix(deps): update dependency puppeteer-core to v22 #4621

merged 3 commits into from
Jul 9, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 5, 2024 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
puppeteer-core (source) 21.11.0 -> 22.6.0 age adoption passing confidence

Release Notes

puppeteer/puppeteer (puppeteer-core)

v22.6.0

Compare Source

v22.5.0: puppeteer: v22.5.0

Compare Source

Miscellaneous Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated

v22.4.1: puppeteer: v22.4.1

Compare Source

Miscellaneous Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 22.4.0 to 22.4.1

v22.4.0: puppeteer-core: v22.4.0

Compare Source

Features
Bug Fixes
  • roll to Chrome 122.0.6261.94 (r1250580) (#​12012) (7ba5529)
  • webdriver: wait for response if the response has not completed once navigation has finished (#​12018) (6d8831a)

v22.3.0: puppeteer-core: v22.3.0

Compare Source

Features
Bug Fixes

v22.2.0: puppeteer: v22.2.0

Compare Source

Features
Dependencies
  • The following workspace dependencies were updated

v22.1.0: puppeteer: v22.1.0

Compare Source

Miscellaneous Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated

v22.0.0: puppeteer: v22.0.0

Compare Source

⚠ BREAKING CHANGES
  • remove PUPPETEER_DOWNLOAD_PATH in favor of PUPPETEER_CACHE_DIR (#​11605)
  • drop support for node16 (#​10912)
Features
Dependencies
  • The following workspace dependencies were updated

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Feb 5, 2024
@renovate renovate bot force-pushed the renovate/puppeteer-core-22.x branch 2 times, most recently from 7c5b685 to 9eafa81 Compare February 22, 2024 09:50
@renovate renovate bot force-pushed the renovate/puppeteer-core-22.x branch 2 times, most recently from 073f1f7 to 2efc14a Compare February 29, 2024 19:40
@renovate renovate bot force-pushed the renovate/puppeteer-core-22.x branch 3 times, most recently from 1d8e3ee to 0f66c00 Compare March 8, 2024 12:25
@renovate renovate bot force-pushed the renovate/puppeteer-core-22.x branch 2 times, most recently from df5225f to fef7d01 Compare March 20, 2024 11:31
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Mar 23, 2024 •
edited
Loading

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@BacLuc BacLuc force-pushed the renovate/puppeteer-core-22.x branch from 5c10649 to e46fa65 Compare March 23, 2024 19:40
usu
usu requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incognito mode was by purpose to avoid cookies leaking inbetween requests. This should be kept.

createIncognitoBrowserContext was renamed to createBrowserContext

https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.0.0

@BacLuc
print: replace createIncognitoBrowserContext with createBrowserContext
0b64395 
Else we have the error:
ERROR  browser.createIncognitoBrowserContext is not a function
 at Object.handler (server/api/pdf.js:51:1)
 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
 at async node_modules/h3/dist/index.mjs:1962:19
 at async Object.callAsync (node_modules/unctx/dist/index.mjs:72:16)
 at async Server.toNodeHandle (node_modules/h3/dist/index.mjs:2249:7)

Which was changed in
https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.0.0
with PR puppeteer/puppeteer#11834

Which seems related to:
puppeteer/puppeteer#2608
@BacLuc BacLuc force-pushed the renovate/puppeteer-core-22.x branch from e46fa65 to 0b64395 Compare March 24, 2024 16:14
@BacLuc
Copy link
Contributor

BacLuc commented Mar 24, 2024

The incognito mode was by purpose to avoid cookies leaking inbetween requests. This should be kept.

createIncognitoBrowserContext was renamed to createBrowserContext

https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v22.0.0

But with that it does not work in the development mode with hot module reloading.
(The production mode seems to work as you can see from the ci).

Another issue having this problem: puppeteer/puppeteer#2608

And isnt' this enough?

ecamp3/docker-compose.yml

Line 179 in 1ec6efd

- FUNCTION_ENABLE_INCOGNITO_MODE=true

@BacLuc BacLuc requested a review from usu April 10, 2024 20:24
@usu usu requested a review from carlobeltrame April 13, 2024 21:16
@BacLuc BacLuc requested a review from pmattmann April 14, 2024 10:50
@renovate renovate bot changed the title fix(deps): update dependency puppeteer-core to v22 fix(deps): update dependency puppeteer-core to v22 - abandoned Apr 14, 2024
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Apr 14, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@usu usu requested a review from manuelmeister April 27, 2024 05:43
@BacLuc BacLuc changed the title fix(deps): update dependency puppeteer-core to v22 - abandoned fix(deps): update dependency puppeteer-core to v22 May 12, 2024
@BacLuc BacLuc added Meeting Discuss Am nächsten Core-Meeting besprechen and removed Meeting Discuss Am nächsten Core-Meeting besprechen labels Jun 1, 2024
@BacLuc BacLuc requested a review from a team July 9, 2024 19:30
@pmattmann pmattmann added this pull request to the merge queue Jul 9, 2024
Merged via the queue into devel with commit b2829fd Jul 9, 2024
59 checks passed
@pmattmann pmattmann deleted the renovate/puppeteer-core-22.x branch July 9, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usu usu usu approved these changes

@pmattmann pmattmann pmattmann approved these changes

@carlobeltrame carlobeltrame Awaiting requested review from carlobeltrame

@manuelmeister manuelmeister Awaiting requested review from manuelmeister

Assignees
No one assigned
Labels
renovate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BacLuc @usu @pmattmann