Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to upgrade between versions. #90

Open
cball opened this issue Oct 19, 2020 · 4 comments
Open

Determine how to upgrade between versions. #90

cball opened this issue Oct 19, 2020 · 4 comments
Labels
chore Tasks unrelated to features, fixes, or docs

Comments

@cball
Copy link
Member

cball commented Oct 19, 2020

2 proposed ways to attack this:

  1. Create a demo repo. Every time we release a new version of bison, we regenerate the app and create a tag. This tag should match the current version of Bison at the time of creation. If we save the version of Bison that was used to generate, we can create a link in the CLI to the git diff. This should give users a step-by-step way to upgrade and is similar to how react-native-upgrade-helper works.
  2. Create a bison package that manages the dependencies, write codemods using jscodeshift to patch files appropriately. This is likely the future solution that we could move to once things have stabilized. It does require some dev work to implement properly.
@cball
Copy link
Member Author

cball commented Oct 19, 2020

Demo repo is here: https://github.com/echobind/bisonapp-versions

Part 2 can be a future enhancement. After #89 is complete, we can add a simple package to manage dependencies and determine the version of Bison that users used initially. This will allow us to generate a diff link using the tags in https://github.com/echobind/bisonapp-versions as the source of truth.

@cball
Copy link
Member Author

cball commented Oct 19, 2020

Example diff on demo repo: echobind/bisonapp-versions@v1.7.3...v1.7.4

@cball
Copy link
Member Author

cball commented Oct 22, 2020

With #95, our short term solution will be to have folks manually generate a link to bisonapp-versions based on the version of Bison in their package.json file.

We'll followup with a new package after #89 is done.

@cball cball added the chore Tasks unrelated to features, fixes, or docs label Oct 22, 2020
@cball
Copy link
Member Author

cball commented Oct 27, 2020

Newly generated Bison projects should have version information in the package.json file. In the short term, users can use this version to construct a manual diff.

As a followup, we can add a simple script that generates the link for them until #89 is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Tasks unrelated to features, fixes, or docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant