Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.4.20 - add pagination to pager command #335

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Release v1.4.20 - add pagination to pager command #335

merged 2 commits into from
Sep 25, 2023

Conversation

echoboomer
Copy link
Collaborator

Describe your changes

  • Adds pagination logic for collections to handle internal pagination.
  • Adds pagination logic to the pager command to iterate via a globally controllable per_page value. This sends a separate message for every per_page items in a collection to avoid breaking Slack's block limit.
  • Formatting changes in a few places.
  • Refactors method used to collect on call data from PagerDuty.

Issue number and link

#328

Checklist before requesting a review

  • I have properly bumped all version refs by running ./scripts/version-bump.sh old new from project root - for example ./scripts/version-bump.sh 1.4.8 1.4.9
  • I have added or changed tests as part of this pull request
  • I will open a pull request for the Helm chart to bump the app and chart versions

@echoboomer echoboomer merged commit 23ffea6 into main Sep 25, 2023
1 check passed
@echoboomer echoboomer deleted the v1.4.20 branch September 25, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant