Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP: User Auth #3

Closed
echurilov opened this issue Oct 14, 2018 · 3 comments
Closed

MVP: User Auth #3

echurilov opened this issue Oct 14, 2018 · 3 comments
Assignees

Comments

@echurilov
Copy link
Owner

User auth has:

  • register (sign up)
  • log in
  • log out
  • log in as demo user
  • display errors on form submission
  • displaying errors does not move around other elements
  • clear errors on resubmit/moving between pages
  • styling closely resembles actual site (for splash, login, & register pages)
@eshoule
Copy link
Collaborator

eshoule commented Oct 15, 2018

Looking good! Please address the unchecked issues, and then I can close this.

User Auth

Functionality

  • The main button with logo should link to /
  • When I click on the logo from the login/signup pages it does not bring me back to the splash /.
  • Has working demo login
  • The demo login button works from the splash page, but not from the login page.

Before Login

  • The /login page should not display a link to Log In. Same for /signup
  • Going to a random route /#/oweiniouewbrviuwebv should redirect or display a 404 page
  • Errors should display for both /signup and /login.
  • Errors should clear when moving between /signup and /login.
  • Can sign up a user
  • Can sign in as a user
  • Can log out a user
  • Can't sign up with the same username/email
  • I can sign up with a different email, but the same username.
  • Pressing enter after filling out the session form should use the form data, not the demo user

After Login

  • Should not be able to visit /login or /signup
  • Should be able to refresh the page and still be logged in

Style

  • The site should look exactly like the actual site
  • All relevant elements should have cursor: pointer on hover
  • When errors are displayed, most elements should not move around the page (particularly input boxes)

@echurilov
Copy link
Owner Author

echurilov commented Oct 15, 2018

  • Added link to logos on /login and /register
  • Uncommented handleDemo for /login (whoops)
  • Where is the link I should remove? I'm not sure which you mean
  • Being able to sign in with a different email and the same username is working as intended; Discord requires unique emails but allows users to have the same username (it assigns them an ID number to disambiguate)

@eshoule
Copy link
Collaborator

eshoule commented Oct 17, 2018

Good job!

@eshoule eshoule closed this as completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants