Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring storage strategies #1741

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Configuring storage strategies #1741

merged 1 commit into from
Dec 16, 2020

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Dec 15, 2020

  • Move Configuring storage strategies to the Installation Guide.
  • Fix xref pointing to this section.

@themr0c themr0c requested review from ibuziuk and removed request for a team December 15, 2020 11:00
@themr0c themr0c added the need-cherry-pick/7.32.x need cherry-pick to 7.32.x label Dec 15, 2020
@themr0c
Copy link
Contributor Author

themr0c commented Dec 15, 2020

As I am just moving some existing content, it is expected that vale checks fail.

@themr0c
Copy link
Contributor Author

themr0c commented Dec 15, 2020

Linkchecker fail is also unrelated. Will look at it in another PR.

yhontyk
yhontyk approved these changes Dec 15, 2020
View reviewed changes
Copy link

@yhontyk yhontyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themr0c
Copy link
Contributor Author

themr0c commented Dec 16, 2020

Skipping the second review, as this PR is only moving already existing content.

@themr0c themr0c removed the request for review from ibuziuk December 16, 2020 10:02
@themr0c themr0c merged commit cf28115 into eclipse-che:master Dec 16, 2020
@themr0c themr0c deleted the move-configureing-storage-strategies branch December 16, 2020 10:02
@sparkoo sparkoo mentioned this pull request Feb 23, 2021
Closed
@themr0c themr0c removed the need-cherry-pick/7.32.x need cherry-pick to 7.32.x label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhontyk yhontyk yhontyk approved these changes

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@rkratky rkratky Awaiting requested review from rkratky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themr0c @yhontyk @che-bot