Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new architecture with DevWorkspace operator (part 1 - server side) #2041

Closed
wants to merge 2 commits into from

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Jun 24, 2021

What issues does this PR fix or reference?

eclipse-che/che#18887

image

image

image

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been configured on the docs side):

@themr0c themr0c added this to In progress in Reviews via automation Jun 24, 2021
@themr0c themr0c modified the milestones: 7.30.x, 7.33.x Jun 24, 2021
@MichalMaler MichalMaler self-assigned this Jun 25, 2021
Comment on lines 18 to 20
* xref:administration-guide:che-workspace-controller-with-dw.adoc[]
* xref:administration-guide:che-workspaces-architecture-with-dw.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pages don't exist. (See link checker errors).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this caused by a fork from the old master branch?

@l0rd
Copy link
Contributor Author

l0rd commented Jun 25, 2021

@themr0c @MichalMaler it's in draft mode, it's not ready for review yet.

@MichalMaler MichalMaler assigned l0rd and unassigned l0rd and MichalMaler Aug 2, 2021
@MichalMaler MichalMaler modified the milestones: 7.33.x, 7.34.x Aug 2, 2021
@l0rd l0rd changed the title feat(new architecture): add articles about the new architecture of Che using DevWorkspace as workspace engine feat: new architecture with DevWorkspace Operator Aug 8, 2021
@l0rd l0rd changed the title feat: new architecture with DevWorkspace Operator feat: new architecture with DevWorkspace operator Aug 8, 2021
@l0rd l0rd changed the title feat: new architecture with DevWorkspace operator feat: new architecture with DevWorkspace operator (part 1 - server side) Aug 8, 2021
@l0rd l0rd force-pushed the future-architecture branch 3 times, most recently from b4cc652 to 7a1051e Compare August 8, 2021 23:15
@l0rd l0rd marked this pull request as ready for review August 8, 2021 23:19
@l0rd l0rd requested review from rkratky and a team as code owners August 8, 2021 23:19
@l0rd
Copy link
Contributor Author

l0rd commented Aug 8, 2021

@MichalMaler this PR is ready for review. The second part (workspaces side changes) will be submitted in a separate PR after this one gets merged.

@l0rd l0rd assigned MichalMaler and unassigned l0rd Aug 8, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Aug 19, 2021

@themr0c @MichalMaler I have solved the conflicts.

@l0rd l0rd force-pushed the future-architecture branch 2 times, most recently from 645cdf8 to 3311624 Compare August 24, 2021 21:40
Signed-off-by: mloriedo <mario.loriedo@gmail.com>
@themr0c
Copy link
Contributor

themr0c commented Oct 1, 2021

Replaced by #2125

@themr0c themr0c closed this Oct 1, 2021
Reviews automation moved this from In progress to Done Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
4 participants