Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: architecture with the DevWorkspace engine #2125

Merged
merged 31 commits into from
Dec 6, 2021
Merged

docs: architecture with the DevWorkspace engine #2125

merged 31 commits into from
Dec 6, 2021

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Oct 1, 2021 •
edited
Loading

Signed-off-by: mloriedo mario.loriedo@gmail.com

What does this pull request change?

Major rework of the Architecture chapter.

What issues does this pull request fix or reference?

Include the architecture based on the DevWorkspace engine.

The chapter about workspaces is still incomplete, and will receive an update later on.

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@themr0c themr0c requested review from MichalMaler, rkratky and a team as code owners October 1, 2021 10:36
@themr0c themr0c requested a review from benoitf October 1, 2021 10:36
@themr0c themr0c marked this pull request as draft October 1, 2021 10:38
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Click here to review and test in web IDE: Contribute

@themr0c
Copy link
Contributor Author

themr0c commented Oct 1, 2021

Same branch as in l0rd#2, but here the merge conflicts don't appear.

@themr0c
Copy link
Contributor Author

themr0c commented Oct 1, 2021

Replaces #2041

This was referenced Oct 1, 2021
Closed
Closed
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Click here to review and test in web IDE: Contribute

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Click here to review and test in web IDE: Contribute

@themr0c themr0c changed the title feat: new architecture with DevWorkspace operator (part 1 - server side) feat: architecture with the DevWorkspace engine Oct 1, 2021
@themr0c themr0c marked this pull request as ready for review October 1, 2021 14:09
@themr0c themr0c requested a review from l0rd October 1, 2021 14:13
@themr0c themr0c added this to the 7.36.x milestone Oct 1, 2021
@themr0c themr0c added the need-cherry-pick/7.36.x base for CRW 2.12 label Oct 1, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Click here to review and test in web IDE: Contribute

jc-berger
jc-berger reviewed Oct 6, 2021
View reviewed changes
modules/administration-guide/partials/con_che-devfile-registry.adoc Outdated
@@ -1,22 +1,15 @@
// Module included in the following assemblies:
//
// {prod-id-short}-workspace-controller
// {prod-id-short}-workspace-controller-with-che-server

[id="{prod-id-short}-devfile-registry_{context}"]
= {prod-short} Devfile registry
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devfile should not be capitalized in this title.

Che devfile registry

l0rd
l0rd reviewed Nov 30, 2021
View reviewed changes
tools/create_architecture_diagrams.py Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_architecture-overview.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_architecture-overview.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_architecture-overview.adoc Show resolved Hide resolved
modules/administration-guide/partials/con_architecture-overview-with-devworkspace.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_devfile-registries.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_che-server-with-devworkspace.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_che-server-with-devworkspace.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_devworkspace-operator.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_che-server-components.adoc Show resolved Hide resolved
themr0c and others added 2 commits December 1, 2021 09:12
@themr0c @l0rd
Apply suggestions from code review
a6dd7f0 
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@themr0c @l0rd
Update modules/administration-guide/partials/con_architecture-overvie…
a0484d6 
…w-with-devworkspace.adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
l0rd
l0rd approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@themr0c themr0c mentioned this pull request Dec 6, 2021
Merged
@themr0c themr0c merged commit 3e70bea into eclipse-che:master Dec 6, 2021
@themr0c themr0c deleted the l0rd-future-architecture branch December 6, 2021 11:04
@themr0c themr0c modified the milestones: 7.40, 7.38 Dec 6, 2021
themr0c added a commit that referenced this pull request Dec 6, 2021
@themr0c @bburt-rh
@missmesss @l0rd
docs: architecture with the DevWorkspace engine (#2125)
df4ba29 
Co-authored-by: Brian Burt <86380613+bburt-rh@users.noreply.github.com>
Co-authored-by: Olga Tikhomirova <85509260+missmesss@users.noreply.github.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: mloriedo <mario.loriedo@gmail.com>
themr0c added a commit that referenced this pull request Dec 6, 2021
@themr0c @bburt-rh
@missmesss @l0rd
docs: architecture with the DevWorkspace engine (#2125)
768ed1e 
Co-authored-by: Brian Burt <86380613+bburt-rh@users.noreply.github.com>
Co-authored-by: Olga Tikhomirova <85509260+missmesss@users.noreply.github.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: mloriedo <mario.loriedo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bburt-rh bburt-rh bburt-rh left review comments

@missmesss missmesss missmesss left review comments

@jc-berger jc-berger jc-berger left review comments

@rolfedh rolfedh rolfedh left review comments

@rkratky rkratky rkratky approved these changes

@l0rd l0rd l0rd approved these changes

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@benoitf benoitf Awaiting requested review from benoitf benoitf was automatically assigned from eclipse/ecd-che-docs-reviewers

Assignees

@themr0c themr0c

Labels
cherry-picked to 7.38.x
Projects
None yet
Milestone
7.38
Development

Successfully merging this pull request may close these issues.
8 participants
@themr0c @rolfedh @l0rd @rkratky @jc-berger @missmesss @bburt-rh @che-bot