Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail if imagePuller CRD does not exist #700

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Mar 4, 2021

What does this PR do?

Do not fail if imagePuller CRD does not exist.

I did the minimal changes which should fix the issue but that logic in general it seems complex and may have other bugs.

What issues does this PR fix or reference?

It fixes eclipse-che/che#19207 on my RHPDS instance.

How to test this PR?

I tested only deploying Che with imagePuller disabled, before it failed with

"Error uninstalling Image Puller: no matches for kind \"KubernetesImagePuller\" in version \"che.eclipse.org/v1alpha1\""

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@sleshchenko sleshchenko changed the title Do not fail if imagePuller CRD does not exist WIP Do not fail if imagePuller CRD does not exist Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #700 (4db0d07) into master (d2e4ba9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   32.68%   32.69%           
=======================================
  Files          50       50           
  Lines        5452     5451    -1     
=======================================
  Hits         1782     1782           
+ Misses       3402     3401    -1     
  Partials      268      268           
Impacted Files Coverage Δ
pkg/deploy/kubernetes_image_puller.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e4ba9...4db0d07. Read the comment docs.

@sleshchenko sleshchenko changed the title WIP Do not fail if imagePuller CRD does not exist Do not fail if imagePuller CRD does not exist Mar 9, 2021
Copy link
Member Author

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha fixes LGTM )

@metlos
Copy link
Contributor

metlos commented Mar 9, 2021

Note that I've seen this on OpenShift 4.4.6, 4.6 and 4.7. On clusters where this was not happening, it started happening for me after 5-10 rescalings of the che-operator. I did the rescaling (to 0 and back to 1) to restart the operator and force a reconcile while debugging my wip changes.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, sleshchenko, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrienkoAleksandr
Copy link
Contributor

/test v7-che-operator-single-host-nightly-deployment

@AndrienkoAleksandr
Copy link
Contributor

/test v6-che-operator-olm-nightly-deployment

sleshchenko and others added 2 commits March 10, 2021 09:44
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit ddcabcb into master Mar 11, 2021
@tolusha tolusha deleted the imagePullerRemoving branch March 11, 2021 08:13
@che-bot che-bot added this to the 7.27 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Che operator enable to reconcile CheCluster due KubernetesImagetPuller CRD lack
6 participants