-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fail if imagePuller CRD does not exist #700
Conversation
bab5e6c
to
d7b013f
Compare
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 32.68% 32.69%
=======================================
Files 50 50
Lines 5452 5451 -1
=======================================
Hits 1782 1782
+ Misses 3402 3401 -1
Partials 268 268
Continue to review full report at Codecov.
|
d7b013f
to
11ef783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tolusha fixes LGTM )
Note that I've seen this on OpenShift 4.4.6, 4.6 and 4.7. On clusters where this was not happening, it started happening for me after 5-10 rescalings of the che-operator. I did the rescaling (to 0 and back to 1) to restart the operator and force a reconcile while debugging my wip changes. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, sleshchenko, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test v7-che-operator-single-host-nightly-deployment |
/test v6-che-operator-olm-nightly-deployment |
fcb81c0
to
4db0d07
Compare
New changes are detected. LGTM label has been removed. |
What does this PR do?
Do not fail if imagePuller CRD does not exist.
I did the minimal changes which should fix the issue but that logic in general it seems complex and may have other bugs.
What issues does this PR fix or reference?
It fixes eclipse-che/che#19207 on my RHPDS instance.
How to test this PR?
I tested only deploying Che with imagePuller disabled, before it failed with
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.