Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory limits configuration into walking skeleton flow #11097

Closed
1 of 3 tasks
garagatyi opened this issue Sep 6, 2018 · 2 comments
Closed
1 of 3 tasks

Add memory limits configuration into walking skeleton flow #11097

garagatyi opened this issue Sep 6, 2018 · 2 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

garagatyi commented Sep 6, 2018

Description

Now we don't have memory limits in the walking skeleton. This leads us to a situation when all the sidecars irrespective of their RAM usage a configured with the default machine RAM limit - 1GB, for example.
We can improve this situation by implementing the next steps:

  • 1. Add a field in the sidecar config to allow the author of the plugin to configure memory limit.
    This would address sidecars with still RAM consumption that doesn't depend on the workspace projects size.
  • 2. Add a property to Che master that would configure the default memory limit for sidecars with small enough value, such as 128MB.
    This would address a case when the plugin author didn't set memory limit and the default Che machine limit is too high for a sidecar.
  • 3. Allow a user to specify workspace config attribute that would override sidecar memory limit from sidecar definition or default sidecar memory limit.
    This would address a situation with JDT.LS like sidecars when usage of RAM depends on the workspace projects size and not really possible to be predicted by the author of a plugin.

Reproduction Steps

OS and version:

Diagnostics:

@garagatyi
Copy link
Author

@skabashnyuk @l0rd @benoitf I'm going to add a field memory-limit to the Container object of the plugin from the WS.NEXT model. It will support kubernetes notion of memory limits, such as: E, P, T, G, M, K, Ei, Pi, Ti, Gi, Mi, Ki - 10Gi, 300Ki.
If you have ideas what can be implemented in a better way, please, comment.

@garagatyi
Copy link
Author

Closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

2 participants