Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to specify path for command execution in its configuration #11866

Closed
mshaposhnik opened this issue Nov 8, 2018 · 9 comments
Closed
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@mshaposhnik
Copy link
Contributor

mshaposhnik commented Nov 8, 2018

Description

To make command execution more flexible and compatible with new devfile feature, it is proposed to add possibility to specify the path inside machine where the command should be executed.
It can be passed through the workingDir attribute of the command.
Example:

{ 
 "commandLine": "mvn clean install", 
  "name": "console-java-simple:build", 
  "attributes": { 
        "goal": "Build", 
        "machineName": "dev-machine", 
  >>>>>>"workingDir": "/projects/console-java-simple"
    }
}
@garagatyi
Copy link

In Che 7 use-case machine name is controlled by a plugin author and Che master code. So, it is subject to change without user awareness. And if this happens a command would not work.

@skabashnyuk skabashnyuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Nov 8, 2018
@sleshchenko sleshchenko changed the title Make it possible to specify path for command execution in it's configuration Make it possible to specify path for command execution in its configuration Nov 26, 2018
@AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Nov 27, 2018
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Nov 27, 2018
@AndrienkoAleksandr
Copy link
Contributor

Blocked by kubernetes/kubernetes#71350

@l0rd
Copy link
Contributor

l0rd commented Feb 19, 2019

Can't we just cd <working-dir>; <command>?

@l0rd
Copy link
Contributor

l0rd commented Feb 20, 2019

@AndrienkoAleksandr ^^ ?

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Feb 20, 2019

Can't we just cd <working-dir>; <command>?

Yes, we can do it like workaround.

@l0rd
Copy link
Contributor

l0rd commented Feb 20, 2019

Yes, we can do it like workaround.

Ok let's start with that because I am afraid it will take years to have a patch on Kubernetes

@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. labels Mar 11, 2019
@l0rd l0rd mentioned this issue Mar 19, 2019
@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 21, 2019
@sleshchenko
Copy link
Member

@AndrienkoAleksandr Looks like exec sidecar respects workingDir in command attributes, does not matter with a workaround (cd workindDir && ...), right?
If yes, then can we close this issue?

@skabashnyuk
Copy link
Contributor

@AndrienkoAleksandr wdyt ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

6 participants