Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined Che launch commands should be exported in a launch.json file #12711

Closed
l0rd opened this issue Feb 20, 2019 · 2 comments
Closed

User defined Che launch commands should be exported in a launch.json file #12711

l0rd opened this issue Feb 20, 2019 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 20, 2019

Description

Currently, when a user defines a debug command (in a devfile or from the Che dashboard), he won't be able to run it from Theia Debug menu.

Solving this issue requires to solve #12710 first.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 20, 2019
@vparfonov
Copy link
Contributor

Look like for implement this task we need to change commands description in Eclipse Che API. It because in Che we just have command line but in Theia (VS Code) command launch procedure depends on Extension logic.

@l0rd
Copy link
Contributor Author

l0rd commented Feb 27, 2019

Look like for implement this task we need to change commands description in Eclipse Che API. It because in Che we just have command line but in Theia (VS Code) command launch procedure depends on Extension logic.

@vparfonov breaking the API for Che 7 is not a problem but we need to document the change and communicate it in che-dev. You don't provide much information about the solution ("we need to change commands description") but it's important to decouple the solution from Theia: I mean Theia is one editor, Che may have other editors. Che command abstraction should work with any editors.

@l0rd l0rd mentioned this issue Apr 2, 2019
@RomanNikitenko RomanNikitenko self-assigned this May 8, 2019
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label May 8, 2019
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants