Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile: tools should be renamed components #12836

Closed
l0rd opened this issue Mar 6, 2019 · 1 comment
Closed

Devfile: tools should be renamed components #12836

l0rd opened this issue Mar 6, 2019 · 1 comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 6, 2019

Description

Component is a better name. It's more generic and tools is ok for IDE tools (language suppport, debugging etc...) but less for IDE runtimes (application servers, databases etc....) or editors (e.g. theia).

And we need to do the renaming also to align with odo terminology

So a devfile would look like:

---
specVersion: 0.0.1
name: petclinic-dev-environment
projects:
     (...)
components:
     (...)
commands:
   - name: (...)
     actions:
       - type: exec
         component: mysql
         (...)
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 6, 2019
@skabashnyuk skabashnyuk added severity/P1 Has a major impact to usage or development of the system. and removed team/osio labels Mar 6, 2019
@skabashnyuk
Copy link
Contributor

This is an incompatible change. That means that if we do that devfiles with "tools" would not work. We have "spec Version" to handle such a situation in the future. But at this time we have no code behind it to support incompatible changes. If we take in to account amount of other work "devfile" related work and the fact that we are in 7.x-beta it doesn't make sense to spend a lot of time on backward support before GA. So the plan:

  • to do a change
  • send a note to the mail list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants