Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devworkspace] Finalize Workspace Reconcile loop rework #16494

Closed
sleshchenko opened this issue Mar 31, 2020 · 1 comment
Closed

[devworkspace] Finalize Workspace Reconcile loop rework #16494

sleshchenko opened this issue Mar 31, 2020 · 1 comment
Assignees
@amisevsk
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sleshchenko
Copy link
Member

Is your enhancement related to a problem? Please describe.

We have POC for a redesign of the Che workspace operator. The main goals there are:

  1. Improve the main reconcile loop to delegate time-consuming steps to subcontrollers
  2. Establish a clearer separation of concerns between different components of the controller, and simplify how data flows between different steps in the reconcile loop
  3. Allow workspace routing to contribute to the main workspace deployment, in order to support in-deployment proxy containers for auth
  4. Do full reconciles on all elements of a workspace; if a route is deleted or modified it should be recreated.

It the scope of this issue it's needed to finalize the work in the repo and move it back to main repo in che-incubator
@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. team/controller severity/P1 Has a major impact to usage or development of the system. labels Mar 31, 2020
@sleshchenko sleshchenko mentioned this issue Mar 31, 2020
Closed
@sleshchenko sleshchenko mentioned this issue Mar 31, 2020
Closed
@amisevsk amisevsk mentioned this issue Apr 1, 2020
Merged
@amisevsk
Copy link
Contributor

amisevsk commented Apr 7, 2020

PR is merged 🎉

@amisevsk amisevsk closed this as completed Apr 7, 2020
@l0rd l0rd mentioned this issue Apr 16, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sleshchenko @amisevsk