Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php stack: the command Configure Apache Web Server DocumentRoot should be done in the entrypoint (command) or CMD (args) #16869

Open
sunix opened this issue May 7, 2020 · 2 comments
Labels
area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ area/languages Issues related to Language extensions or plugins integration. good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented May 7, 2020

Is your enhancement related to a problem? Please describe.

Starting the php stack, we ask the user to do a step that could be done automatically:

https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/php-web-simple/devfile.yaml#L53

- name: Configure Apache Web Server DocumentRoot
  actions:
    - type: exec
      component: php
      command: |
        if grep -q '/projects$' /etc/apache2/sites-available/000-default.conf; then
          sed -i 's|DocumentRoot /projects|DocumentRoot /projects/php-web-simple|' /etc/apache2/sites-available/000-default.conf
        else
          echo "DocumentRoot already configured!"
        fi

We could simply call that script in the entrypoint ( following by sleep as usual ).
it would avoid user having to do that him self

image

@sunix sunix added the kind/enhancement A feature request - must adhere to the feature request template. label May 7, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 7, 2020
@ibuziuk ibuziuk added the area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ label May 8, 2020
@ibuziuk
Copy link
Member

ibuziuk commented May 8, 2020

@sunix are you going to work on this task? Could you please set the labels based on priorities? (PHP stack is quite popular)

@rkratky rkratky added area/languages Issues related to Language extensions or plugins integration. severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 8, 2020
@sunix sunix added the good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! label Jun 26, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ area/languages Issues related to Language extensions or plugins integration. good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants