Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard should respect registry.devfile.io deployed on the cluster #22454

Closed
tolusha opened this issue Aug 24, 2023 · 2 comments · Fixed by eclipse-che/che-dashboard#935
Closed

Dashboard should respect registry.devfile.io deployed on the cluster #22454

tolusha opened this issue Aug 24, 2023 · 2 comments · Fixed by eclipse-che/che-dashboard#935
Assignees
@olexii4
Labels
area/dashboard area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@tolusha
Copy link
Contributor

tolusha commented Aug 24, 2023 •
edited
Loading

Is your task related to a problem? Please describe

If registry.devfile.io is deployed on the cluster [1], then dashboard try to read index file by path /devfiles/index.json instead of /index. For instance see [2]

[1] https://github.com/devfile/registry-operator
[2] https://registry.devfile.io/index

Describe the solution you'd like

Operator configures dashboard with devfile registry url and path to read index file via environment variables.

Describe alternatives you've considered

Dashboard should try to read index file from both paths to figure out the proper path.

Additional context

No response
@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. area/dashboard area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 24, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 24, 2023
@ibuziuk ibuziuk added sprint/next severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 25, 2023
@tolusha tolusha added this to the 7.74 milestone Aug 29, 2023
@tolusha tolusha mentioned this issue Aug 30, 2023
Merged
9 tasks
@ibuziuk
Copy link
Member

ibuziuk commented Sep 6, 2023

@tolusha can we close the issue?

@tolusha
Copy link
Contributor Author

tolusha commented Sep 6, 2023

No, we still need changes on dashboard side to support custom devfile registry deployed on the cluster.

@ibuziuk ibuziuk removed this from the 7.74 milestone Sep 6, 2023
@svor svor mentioned this issue Sep 15, 2023
Merged
@tolusha tolusha added area/dashboard and removed area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Sep 25, 2023
@olexii4 olexii4 mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olexii4 olexii4

Labels
area/dashboard area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: registry index URL eclipse-che/che-dashboard
4 participants
@ibuziuk @tolusha @olexii4 @che-bot