Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfooding improvements to use Che to build Che #5529

Closed
6 of 8 tasks
vparfonov opened this issue Jul 4, 2017 · 9 comments
Closed
6 of 8 tasks

Dogfooding improvements to use Che to build Che #5529

vparfonov opened this issue Jul 4, 2017 · 9 comments
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@vparfonov
Copy link
Contributor

vparfonov commented Jul 4, 2017

Development experience is a topic of constant improvement and currently there is a bunch of issues that covers the most valuable features that are planned to be improved.

For GWT (important for IDE client development)

For JS/TS (important for User Dashboard development)

@vparfonov vparfonov added the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Jul 4, 2017
@gazarenkov
Copy link
Contributor

Considered as Important for day-by-day using

@gazarenkov
Copy link
Contributor

Here is some context:

In order to preparation discussion in Cherkassy.

Here is the list of IDE issues R&D consider as critical for Che internal using.

Common:

  • slow and not reliable project explorer (especially with big project tree)
  • fully reliable search/ file navigation
  • code formatting
    For Java
  • not reliable class delete/rename/move feature
  • debugger not stable enough and missed several important features
  • unstable test unit runner
  • autocompletion performance
    For GWT (important for IDE client development)
  • broken Super Dev Mode
    For JS/TS (important for User Dashboard development)
  • TypeScript project: autocomplete, go to declaration, find usages

PMs' perceptions of it (comparing with other) would be really useful.


Thank you to the team for thoughtful preparation of this.

I have some learning questions:

  1. How is our search unreliable today?
  2. How is test runner unstable?
  3. What is broken on super dev mode?

  1. How is our search unreliable today?

Here problem not only in search, but in file navigation too. We already have several issues with project tree performance like this #3891 .
To make search more reliable we open file watching processes on all directorates/files in /projects this leads to this issue codenvy/codenvy#1723

  1. How is test runner unstable?

It works ok for small project but useless for big project like Che with multi-module structure.

  1. What is broken on super dev mode?

Here also problem with multi-module project with many code source folders. When we develop first version of super-dev mode for Che we hardcoded all modules name in special command but when we add/remove/replace some Maven module this command won't work. So we need to in some way build those paths automatically.


In critical IDE issue I would add the simple text editing completion that is scrolling up my edit window.
When I ask for completion, my browser/edit windows is moving from where it was

here is a simple screencast
after I select code completion and hit enter with selected completion, my whole screen scrolls
Editor lines was from lines 65-95 and after I hit code completion the lines are 54-84

@gazarenkov
Copy link
Contributor

code-completion-move-my-screen

@benoitf
Copy link
Contributor

benoitf commented Jul 6, 2017

@gazarenkov AFAIK the screencast you used is coming from the issue I created there #4397 but this problem should have been fixed right now by #4669

Yes we can't reproduce it anymore

@vparfonov
Copy link
Contributor Author

Few comments:

  1. slow and not reliable project explorer (especially with big project tree) - already fixed
  2. About search we have good request here Improving search results #5174
  3. code formatting problem is - user can't setup own rules for code format Custom Java formatting rules #339
  4. not reliable class delete/rename/move feature - Delete Java class from Project Explorer should consider as Refactoring  #5549
  5. unstable test unit runner - not good description for problem can find more here Test runner plugin improvement  #5429
  6. autocompletion performance - looks like work fine for now can be depend on network

@sunix
Copy link
Contributor

sunix commented Jul 12, 2017

I've added #340 Formatting xml files as part of Code formating

@slemeur slemeur changed the title Development experience improvement Dogfooding improvements to use Che to build Che Sep 6, 2017
@vparfonov
Copy link
Contributor Author

vparfonov commented Oct 10, 2017

Remove code formater because in current state this not critical for Dogfooding you always can format code with mvn fmt:format

@sunix
Copy link
Contributor

sunix commented Oct 16, 2017

@vparfonov can we format xml files with mvn fmt:format ?

@vparfonov
Copy link
Contributor Author

@sunix I am not usre about any XML but pom.xml ypu can format with mvn sortpom:sort

@gorkem gorkem closed this as completed Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

5 participants