Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh17060 gateway single host kube #17557
Gh17060 gateway single host kube #17557
Changes from all commits
a2bb8c9
56a3f8e
1417611
5d3e625
9e275c4
3cfabf4
e0ec48c
641d6ae
eb28dce
2fcd61d
b9de188
6e599ec
cc9ed29
cf56415
7b8497b
3fc2524
067b3b0
97e3de3
de5520c
31e8fa0
4035eb3
f42a4b2
ad2b416
1e163fb
a563b34
721495f
62e2314
66b9d3e
3cd2006
9508e6c
5e6051d
e30d279
8480ba9
183d58c
8d796ae
d5cc155
a82b883
60b626a
e4db204
49375ae
69a03fb
28c8fbe
fe3a96c
ee77b6b
83e4774
c77a4ee
8f1c14e
4d6337c
ec1201d
fe6e99e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better included in this changeset as a
git mv
rather than deleting the earlier file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it would help. imho github or some git visualiser (git log, gitk, etc) are doing some magic to detect moved files, but this one probably changed too much to detect. I don't think git engine itself track this. But I'm not sure, if you know how to do it now retrospectively, I can try.