-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use precreated labeled namespace for workspaces #18090
Merged
sparkoo
merged 14 commits into
eclipse-che:master
from
sparkoo:gh17842-precreatedNamespaces
Oct 20, 2020
Merged
use precreated labeled namespace for workspaces #18090
sparkoo
merged 14 commits into
eclipse-che:master
from
sparkoo:gh17842-precreatedNamespaces
Oct 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <mvala@redhat.com>
che-bot
added
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
kind/task
Internal things, technical debt, and to-do tasks to be performed.
labels
Oct 9, 2020
Signed-off-by: Michal Vala <mvala@redhat.com>
metlos
reviewed
Oct 12, 2020
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
commented
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the labels property to use placeholders, because without them, we would not be able to be really flexible with label names.
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
looks 'ok' in general |
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
requested review from
amisevsk,
ibuziuk,
nickboldt and
sleshchenko
as code owners
October 16, 2020 11:08
@metlos @skabashnyuk @mshaposhnik ready to review |
skabashnyuk
approved these changes
Oct 19, 2020
che-bot
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Oct 20, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
Allow using precreated namespaces labeled with proper labels. The labels are configurable with
che.infra.kubernetes.namespace.labels
property.Documentation PR
eclipse-che/che-docs#1643
TODO:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#17842
How to test this PR?
app.kubernetes.io/part-of=che.eclipse.org,app.kubernetes.io/component=workspace,che.eclipse.org/username=<username>
and make sure your user has access to it (admin
role)admin
role in pre-created project.che
serviceaccount.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.