Prevent inconsistency when allowed user namespaces is false and namespace contains random part. #18209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
amisevsk,
metlos,
nickboldt and
sleshchenko
as code owners
mshaposhnik
requested review from
sparkoo
and removed request for
nickboldt,
sleshchenko and
amisevsk
che-bot
added
status/code-review
metlos
approved these changes
Oct 27, 2020
sparkoo
approved these changes
Oct 27, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some namespace naming inconsistency spotted, when che.infra.kubernetes.namespace.allow_user_defined=false and when we need to normalize the namespace name. PR fixes this situation.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#18178
How to test this PR?
Create a user with invalid symbols in username. Try create/run custom workspaces. Everything should run smooth. namespace name should remain the same.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.