-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated policy of installers update #8406
Merged
sleshchenko
merged 1 commit into
eclipse-che:master
from
sleshchenko:updatePolicyOfInstallerInits
Jan 31, 2018
Merged
Updated policy of installers update #8406
sleshchenko
merged 1 commit into
eclipse-che:master
from
sleshchenko:updatePolicyOfInstallerInits
Jan 31, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
gazarenkov,
skabashnyuk,
tolusha,
garagatyi and
akorneta
January 22, 2018 16:11
benoitf
added
kind/enhancement
A feature request - must adhere to the feature request template.
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
labels
Jan 22, 2018
tolusha
approved these changes
Jan 23, 2018
Dear Reviewers, please review my PR and share your opinion about it. |
sleshchenko
force-pushed
the
updatePolicyOfInstallerInits
branch
from
January 23, 2018 08:05
3e3f01f
to
df57dbe
Compare
garagatyi
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
akorneta
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
skabashnyuk
approved these changes
Jan 23, 2018
sleshchenko
force-pushed
the
updatePolicyOfInstallerInits
branch
from
January 23, 2018 09:20
df57dbe
to
1501352
Compare
gazarenkov
approved these changes
Jan 30, 2018
sleshchenko
force-pushed
the
updatePolicyOfInstallerInits
branch
from
January 30, 2018 16:12
1501352
to
e34e628
Compare
benoitf
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Jan 31, 2018
hkolvenbach
pushed a commit
to hkolvenbach/che
that referenced
this pull request
Mar 2, 2018
…3613 to master * commit 'd800fb816af6ed6f2d67702ac55ff5f8a8be3630': (34 commits) fixed version added new aws run script Prevents displaying installers with empty names and descriptions (eclipse-che#8536) adapt selenium tests according to changes with workspace config updating (eclipse-che#8561) Fix docs link. Dash instead underscore (eclipse-che#8548) fix aws ST-3613 custom keycloak image Dashboard: allow to update workspace config without workpace restarting (eclipse-che#8505) eclipse-che#8509 handle keybinding inside FileStructure Window (eclipse-che#8528) RELEASE: Set next development version (eclipse-che#8496) Add extra steps in the 'prepare()' to increase stability Renew URLs of CI servers to compare local selenium testing results (eclipse-che#8541) Selenium: Add ability to catch Chrome browser`s console logs (eclipse-che#8502) CHE-6923: Provide more space for committer fields in Preferences dialog. (eclipse-che#8480) Restore support of single-port Che mode (on docker infra) Factories links (eclipse-che#8530) CHE-7555 fix resolve factory flow Update policy of installers update (eclipse-che#8406) Improves debug panel, fixes UI of configure breakpoints popup (eclipse-che#8520) Update ProjectExplorerPresenter.java ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates policy of installers update.
Now existing Che installers (exec, wsagent, etc.) must not be modified because they won't be applied to existing instances. Instead of updating new version must be added and them all workspace will pick it up if they use
latest
version.With these changes, existing installers can be modified and they will be picked up by existing Che instances when it will be upgraded.
So, InstallerRegistry will do the following action when tomcat will be started:
Why it is important?
Now there is no a centralized ability to update installers that are already initialized. But IMHO it is so useful in the following cases:
Now in the described cases, we have to create new installer version even when old one becomes broken.
And Dashboard will propose a user to installer broken installer, see example:
The actual difference between these two installers is - new installer is able to use environment variable with a free port for its server while old one always uses default port and will fail if any ports conflicts occur.
For End Users, it's not clear enough what is really a difference between installers and which one they should use. Actually, there is no sense to use an older version.
One of the use cases when It makes sense to have different installers version if they really provide different agents or install different software.
As additional benefit developer life become easier:
"
characters).What issues does this PR fix or reference?
Release Notes
Updated policy of installers update.
Docs PR
N/A