Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: allow to update workspace config without workpace restarting #8505

Merged
merged 6 commits into from
Feb 1, 2018

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jan 29, 2018

What does this PR do?

This PR allows

  • to save changes without applying them and restarting the workspace;
  • to save and apply changes with workspace restarting;
  • to cancel changes which are not saved in the workspace config.

screenshot-localhost-3000-2018-01-29-18-35-17-013

What issues does this PR fix or reference?

resolve #7916
fix #8312

Release Notes

Docs PR

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Component che-edit-mode-overlay is used on the Workspace Details page
intead of workspace-edit-mode-overlay. Unit tests are added.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 29, 2018
@akurinnoy akurinnoy self-assigned this Jan 29, 2018
@akurinnoy
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8505
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova ashumilova added this to the 6.0.0-M5 milestone Jan 30, 2018
@ashumilova ashumilova removed this from the 6.0.0-M5 milestone Jan 30, 2018
@akurinnoy
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8505
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy akurinnoy merged commit 9af54bb into eclipse-che:master Feb 1, 2018
@akurinnoy akurinnoy removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 1, 2018
@benoitf benoitf added this to the 6.1.0 milestone Feb 5, 2018
hkolvenbach pushed a commit to hkolvenbach/che that referenced this pull request Mar 2, 2018
…3613 to master

* commit 'd800fb816af6ed6f2d67702ac55ff5f8a8be3630': (34 commits)
  fixed version
  added new aws run script
  Prevents displaying installers with empty names and descriptions (eclipse-che#8536)
  adapt selenium tests according to changes with workspace config updating (eclipse-che#8561)
  Fix docs link. Dash instead underscore (eclipse-che#8548)
  fix aws
  ST-3613 custom keycloak image
  Dashboard: allow to update workspace config without workpace restarting (eclipse-che#8505)
  eclipse-che#8509 handle keybinding inside FileStructure Window (eclipse-che#8528)
  RELEASE: Set next development version (eclipse-che#8496)
  Add extra steps in the 'prepare()' to increase stability
  Renew URLs of CI servers to compare local selenium testing results (eclipse-che#8541)
  Selenium: Add ability to catch Chrome browser`s console logs (eclipse-che#8502)
  CHE-6923: Provide more space for committer fields in Preferences dialog. (eclipse-che#8480)
  Restore support of single-port Che mode (on docker infra)
  Factories links (eclipse-che#8530)
  CHE-7555 fix resolve factory flow
  Update policy of installers update (eclipse-che#8406)
  Improves debug panel, fixes UI of configure breakpoints popup (eclipse-che#8520)
  Update ProjectExplorerPresenter.java
  ...
@akurinnoy akurinnoy deleted the CHE-7916 branch August 23, 2018 10:21
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
…ng (#8505)

* code clean-up

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* add che-edit-mode-overlay directive, unit test

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* use che-edit-mode-overlay component

Component che-edit-mode-overlay is used on the Workspace Details page
instead of workspace-edit-mode-overlay. Unit tests are added.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* prevent removing projects on stopped workspace

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix cropping of recent workspace names in left navbar

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! use che-edit-mode-overlay component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
5 participants