Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the best way to correctly display JSON files with dark themes? #252

Open
gizmecano opened this issue Nov 15, 2016 · 1 comment
Open

Comments

@gizmecano
Copy link

Using Eclipse PDT Neon.1 with its native Eclipse JSON Editors and Tools, most of the dark themes don't display correctly.

As Eclipse Color Themes is listed among the "plugins that extend or integrate with PDT", I wonder if this problem is only due to the themes I tried to use (dark ones) or if any relationship could exist with the issue opened on July 2011 by @fhd (cf. #63).

On the other hand, according to the current readme.md, Eclipse Color Theme is supposed to support the following editors for JSON:

Maybe the solution is to use one of these three editors ...

But in this case, can we hope soon the support of the native editor included in PDT?

@gizmecano gizmecano changed the title What is the best way to correclty display JSON files with dark themes? What is the best way to correctly display JSON files with dark themes? Nov 15, 2016
@rainysaturday
Copy link

Hi,

I couldn't get the default json editor from Php Development Tools to work properly, it complains about content-type, maybe it works anyway though.

I did look into the other ones though.
Json Eclipse Plugin: This project is deprecated and points to the Eclipse Json Editor Plugin
Eclipse Json Editor Plugin: the mapping for this plugin needs updating since the preference value for colors has changed.
JsonTools: as far as I can tell everything works fine with this one.

With regards to the Eclipse Json Editor Plugin I'll make a pull request with the updated preference values in a minute.

rainysaturday pushed a commit to rainysaturday/eclipse-color-theme that referenced this issue Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants