Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainer email #52

Open
brakmic-aleksandar opened this issue Aug 8, 2022 · 8 comments
Open

Update maintainer email #52

brakmic-aleksandar opened this issue Aug 8, 2022 · 8 comments

Comments

@brakmic-aleksandar
Copy link
Contributor

Maintainer email in package.xml should be updated for all 3 packages (rmw_ecal, shared and proto) :(

@FlorianReimold
Copy link
Member

Unfortunately, we don't have an official maintainer at the moment... I can remove it altogether 😶

@brakmic-aleksandar
Copy link
Contributor Author

I think that might actually cause colcon to throw compile error, i know that some package fields are mandatory, not sure whether maintainer one is.

@JWhitleyWork
Copy link
Contributor

Are you guys still looking for a maintainer? A company I work for is considering using eCAL but this repo definitely needs some work and I would be happy to put that work in but I wanted to make sure there was at least someone keeping an eye on this repo for PRs. I might be willing to maintain this.

@FlorianReimold
Copy link
Member

@JWhitleyWork,

Are you guys still looking for a maintainer?

Yes we are 🙌

A company I work for is considering using eCAL

Happy to hear this 😊
eCAL is very actively maintained. We are working on it on a daily basis and regularly publish updates.

but this repo definitely needs some work and I would be happy to put that work in but I wanted to make sure there was at least someone keeping an eye on this repo for PRs. I might be willing to maintain this.

You are right, this repository needs some work. We didn't change much since our last maintainer left us, unfortunately. He did a great job though and the rmw_ecal still has a great value. But it probably needs some polishing and adaptations to the current ROS2 versions. We also never got around fixing the rmw_ecal + rosidl_typesupport_protobuf issue that occurred with the latest ROS2.
We are still actively watching the repository and still try to solve any questions and issues as good as possible. And - of course - we are here to review and merge any PR that improves it.

For becoming a contributor, you have to:

Now you are good to go! You fork the repo and create PRs, we merge them 👍

@rex-schilasky
Copy link
Contributor

Welcome @JWhitleyWork 🚀. We had a short message exchange on ROS discourse a few years ago regarding eCAL's recording capabilities 😎.

@JWhitleyWork
Copy link
Contributor

@FlorianReimold Account created and linked, DCO signed. Thanks to you and @rex-schilasky for the warm welcome! I'll be playing around with this RMW and doing some benchmarking vs. DDS implementations (localhost and remote) in the near future. I'll let you know if I am able to share the results. :) As for maintainership, I'll let you know if it ends up working out. Either way, I'll submit a PR for any issues I see or features that I need for my testing and we'll see how it goes!

@JWhitleyWork
Copy link
Contributor

@FlorianReimold We've started working with this repository and I would like to clean up some of the branches. Would you be OK with me taking over maintainership? I may need some help in determining the relevancy of some branches.

@FlorianReimold
Copy link
Member

I made you a contributor in Eclipse eCAL. It may take an hour or so, until this is propagated to GitHub.
The bad news is, that this will not give you permission to directly modify branches here, as only committers can do that. As a contributor you can only assign, label, review issues/prs.
There is a rather lengthy Eclipse Process for electing committers and the committer rank comes with a set of responsibilities. Eclipse wants committers to be elected from a list of "significant contributors" (whatever that is 😉), so I suggest we keep it like this for a little bit.

I assume you probably want to rename / delete / create some new branches? If you tell me what it shall look like, I can create it for you. You can also create a target layout on your fork, tell me when you are ready and then I will push it to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants