Bug: Empty criteria list in AssetSelectorExpression results in valid data offers

[juliapampus]

Bug Report

Describe the Bug

Potential misbehavior: When a ContractDefinition is created with an accessPolicyId, contractPolicyId and an empty Criterion list, this ContractDefinition is applied to all Assets and results in a Catalog with ContractOffers that each link the Policy with the contractPolicyId and every single Asset.

Example:

• Create 1 Policy
• Create 1 ContractDefinition (accessPolicyId, contractPolicyId, empty Criterion list)
• 50 Assets

Expected Behavior

Catalog with 0 ContractOffers as the ContractDefinition is invalid and does not point to a single Asset.

Observed Behavior

Catalog with 50 ContractOffers, each Asset linking to the same Policy from the ContractDefinition.

As a result: 50 ContractOffers (empty Criterion list) and 50 registered Assets result in 50x50 ContractOffers in the Catalog.

Possible Implementation

The method queryAssets(AssetSelectorExpression expression) in AssetIndex implementations currently only checks for null objects and the AssetSelectorExpression.SELECT_ALL expression. Filtering should be aborted when the criteria list is empty:

@Override
public Stream<Asset> queryAssets(AssetSelectorExpression expression) {
    Objects.requireNonNull(expression, "AssetSelectorExpression can not be null!");

    // select everything ONLY if the special constant is used
    if (expression == AssetSelectorExpression.SELECT_ALL) {
        return queryAssets(QuerySpec.none());
    }

    // don't continue if no criteria exist
    var criteria = expression.getCriteria();
    if (criteria == null || criteria.isEmpty()) {
        return Stream.empty();
    }

    return queryAssets(QuerySpec.Builder.newInstance().filter(expression.getCriteria()).build());
}

InMemoryAssetIndexTest:

@Test
void queryAssets_missingCriteriaList_returnsEmpty() {
    var testAsset = createAsset("foobar");
    index.accept(testAsset, createDataAddress(testAsset));

    var assets = index.queryAssets(AssetSelectorExpression.Builder.newInstance().build());

    assertThat(assets).isEmpty();
}

@Test
void queryAssets_emptyCriteriaList_returnsEmpty() {
    var testAsset = createAsset("foobar");
    index.accept(testAsset, createDataAddress(testAsset));

    var assets = index.queryAssets(AssetSelectorExpression.Builder.newInstance().criteria(List.of()).build());

    assertThat(assets).isEmpty();
}

[github-actions]

This issue is stale because it has been open for 28 days with no activity.

[ndr-brt]

Is this still valid? empty criteria list stands for "select all", if we want to avoid this behavior for any reason a validation could be added, but I'd say that this can be closed