Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsp: assetId is null on new transfer request #2959

Closed
ndr-brt opened this issue May 11, 2023 · 2 comments · Fixed by #2972
Closed

dsp: assetId is null on new transfer request #2959

ndr-brt opened this issue May 11, 2023 · 2 comments · Fixed by #2972
Labels
bug Something isn't working
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented May 11, 2023

Bug Report

Describe the Bug

When a new transfer is requested, the assetId set in the DataRequest is null, because that information is not set in the TransferRequestMessage.

See TransferProcessProtocolServiceImpl

Expected Behavior

The TransferProcessProtocolServiceImpl.requestedAction should get the agreement from the contractId and extract the assetId from there.

@ndr-brt ndr-brt added the bug Something isn't working label May 11, 2023
@ndr-brt ndr-brt added this to the Milestone 9 milestone May 11, 2023
@ndr-brt
Copy link
Member Author

ndr-brt commented May 11, 2023

EDIT: maybe it could be extracted from the contractId, that now contains the assetId as well
EDIT2: I confirm that the assetId can be extracted from the contractId

@jimmarino
Copy link
Contributor

Yep, previously, I thought this was about the offerId but contracted we can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants