-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AdminGUI incompatibility with GF7 #23782
Comments
This is indeed the case. The Admin GUI, being based on JSF Template/Woodstock is not compatible with Faces 4.0. We likely have to deliver GlassFish 7 without the admin console. I tried to find sponsors, but either people don't understand the issue, or when they do they say to just deliver indeed with the admin console. |
@arjantijms Do you have any clues as to what kind of JSF specification changes are affecting it? |
It's mainly the removal of a lot of deprecated features I guess. |
The issue is also reproducible with glassfish7 M3 release. |
That's correct indeed. |
Now the access to the admin console is successful, but it keeps loading...
it seems necessary to update the following manifest to the latest state glassfish/appserver/admingui/war/pom.xml Lines 133 to 136 in 2e3d8d5
|
Can we perform all operations of Admin Console (https://localhost:4848) either using GlassFish REST Interface (http://localhost:4848/management/domain) or commandline (via asadmin command) ? |
AFAIK, asadmin command basically covers all operations. |
I am trying to migrate woodstock and jsftemplating to JFS4 but having difficulty with JSP de-support (such as UIComponentELTag, FACES-1546) and migration local EL API to Jakarta EL API (FACES-1548). Now I am looking for migration tips. |
@hs536 that's a very brave attempt! |
Current Status
Steps to reproduce
Then, accessing the management console, the following error is output to server.log.
|
Amazing work!
Could this perhaps be related to CDI now needing a |
Hi, Codehttps://github.com/aubi/glassfish-jsftemplating/commits/upgrade-to-faces-4 (pageSession should return the map, not an element from it) Results
This code is perfomed properly:
But later
it is not recognized and ends in I tried also
This is obviously executed by Expressly, which knows nothing about pageSession. I think, that the execution in the second part must go through admin gui evaluation, not Expressly. Nevertheless, it is possible to enter "admin" without password and get logged in, which then fails during initialization of the left Tree, complaining about pageSession. |
The current state of the branches is:
Current problem:
Remainder, branches: |
Yeah, then we could work together as a team, even with some temporal snapshot dependencies ;) |
@arjantijms Yes, I started from the most stable of his branches, glassfish#23782 :-) By Woodstock project you mean https://github.com/eclipse-ee4j/glassfish-woodstock, right? Payara uses patched project. |
The Administration console of M8 build still does not work. (JDK 11, Mac OS)
|
That's why is this issue still open ;) |
+1 Woodstock and JsfTemplate projects have not had any changes since the next version was prepared, so we can merge them into master branch, I think. |
@aubi I creates to "faces4" branches in the jsftemplate and Woodstock projects. Can you push your changes to there? See |
@arjantijms I need one or two weeks for complete my experiments and do some code cleanup, then I can submit my draft |
So, first part, jsftemplating, is done. https://github.com/avpinchuk/glassfish-jsftemplating/commits/ccx-faces4 |
Part 2 of 3, woodstock https://github.com/avpinchuk/glassfish-woodstock/commits/ccx-faces4 |
Last part, GlassFish https://github.com/avpinchuk/glassfish/commits/ccx-fix-admingui |
Yesterday I have created a WIP branch admingui7. |
I tried out the admingui7 branch and it seems that the Admin Console works, at least with the basic scenarios I tried (deploy an app, modify HTTP and Logger config, add password to admin, log in with a password). I fixed a few issues that I discovered with separate PRs into the admingui7 branch. A lot of thanks to you, @avpinchuk, you deserve a mention and thanks in the release notes once GF 7 is released! |
Thanks a lot to everyone involved, amazing work! I'l close this as fixed now. |
Environment Details
GlassFish Version (and build number):
Eclipse GlassFish 7.0.0 (build master-b-g3463ea0 2022-02-05T16:50:42+0000)
Where 3463ea0 is current master.
JDK version:
openjdk version "11.0.14" 2022-01-18
OS: Linux
Database: none
Problem Description
GlassFish Server Administration Console (http://localhost:4848) cannot be loaded.
Seems to be easily reproducible with https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-test-using-jenkinsfile/job/master/611/artifact/bundles/glassfish.zip
server.log
contains:Steps to reproduce
Impact of Issue
Admin GUI is not usable.
The text was updated successfully, but these errors were encountered: